search

nthallen / keutsch-hcho-fcc_v1_6

Atmel Studio Project for Flow Controller Controller Board Using ATSAM21E18
0 stars 0 forks source link

Fix subfunction codes #3

Open nthallen opened 6 years ago

nthallen commented 6 years ago

Currently I have given each customization of the FCC a different subbus subfunction code, but as noted in this related issue, the subfunction is distinct from the instrument code/board ID.

Note that historically, there has been one subbus interface per instrument, but that is no longer true. As such, the Board ID code must identify both the instrument and the interface/board. For HCHO, we have 4 different board IDs allocated: 8:BCtr, 10:FCC, 11:FCC2, and 12:uDACS. Currently, the FCCs are returning subfunctions equal to their Board ID, but that is wrong. They should return an FCC subfunction code. Similarly, the BCtr should return a BCtr subfunction code.

nthallen commented 6 years ago

Note that HCHO does not yet use the DACS_ID.tmc capability to identify boards since there is not currently a C++ wrapper. As such, the subfunction codes are ignored and can be changed with impunity.