nthdimtech / signet-base

Signet firmware and device interface library
https://www.crowdsupply.com/nth-dimension/signet
GNU General Public License v3.0
15 stars 7 forks source link

Add CRC checking to database entries #2

Closed nthdimtech closed 6 years ago

nthdimtech commented 6 years ago

Check CRC after each read or write and notify client if the check detects a problem

nthdimtech commented 6 years ago

This is covered already by flash ECC checking. Just need to make sure that flash ECC error events are processed correctly

dumblob commented 6 years ago

Could you please link here commits which contain the checks for ECC errors and their appropriate handling? I could not find them in the history nor using grep -ir ecc on the whole repository.

nthdimtech commented 6 years ago

More work on ECC error handling needs to be done, that's why issue #6 is still open. I closed this bug to indicate that I was going to use the MCU flash ECC instead of a software CRC. I presently group all errors that occur during writing together and return WRITE_FAILED to whatever command is active while the write was occurring. You can see the code for that in flash_l443xc.c where flash_write_failed() is called.