nthdimtech / signet-base

Signet firmware and device interface library
https://www.crowdsupply.com/nth-dimension/signet
GNU General Public License v3.0
15 stars 7 forks source link

Toolchain #51

Closed lundacode closed 3 years ago

lundacode commented 3 years ago

Hi,

Update to the latest crosstool-ng: 1.24.0".

The purpose is to make firmware building work out of the box in newer Linux versions too: Debian 10 and Ubuntu 20.04.

It is rather straightforward. I've updated the submodule and run ct-ng upgradeconfig for both firmwares.

I've only made two additional changes: 1) disabled an experimental cosmetic feature (CT_ARCH_ARM_TUPLE_USE_EABIHF) that upgradeconfig enabled for some reason. 2) fixed compile warning caused by __packed uint32_t*, this is not supported by gcc.

lundacode commented 3 years ago

Maybe we should leave CT_ARCH_ARM_TUPLE_USE_EABIHF enabled and modify HTUPLE accordingly?

nthdimtech commented 3 years ago

As far as I can see this feature is about making sure you don't get hard and soft float toolchains mixed up which shouldn't be an issue the way the build is setup. I'm in favor of keeping the original tuple and disabling the CT_ARCH_ARM_TUPLE_USE_EABIHF. This can be revisited next time "ct-ng upgradeconfig" needs to be run.

lundacode commented 3 years ago

My thoughts exactly. Then, I guess, this is done.