search

nthdimtech / signet-base

Signet firmware and device interface library
https://www.crowdsupply.com/nth-dimension/signet
GNU General Public License v3.0
15 stars 7 forks source link

Use absolute URLs for submodules #54

Closed sotpapathe closed 3 years ago

sotpapathe commented 3 years ago

With relative URLs if I want to fork signet-client on my profile, I'll have to fork every relative submodule as well.

nthdimtech commented 3 years ago

Yes that's intentional. I may move away from Github in the future and I would like it to be possible for complete forks to exist without changing submodule URL's.

I know it's inconvenient but I think its important that an open source project not contain dependencies to external services unless absolutely necessary to maintain autonomy/independence.

sotpapathe commented 3 years ago

I think its important that an open source project not contain dependencies to external services unless absolutely necessary to maintain autonomy/independence.

Totally with you on this one.

I would like it to be possible for complete forks to exist without changing submodule URL's.

I see, it's more of a tradeoff between complete and partial forks then.

Yes that's intentional.

Didn't see any issues/comments about it, that's why I opened the PRs. I'll close them.

Thanks for making Signet BTW!