ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

feat(web-client): add auto logout #481

Closed billguo99 closed 1 year ago

billguo99 commented 1 year ago

https://app.clickup.com/t/31pkyq8

We want to protect the user by forcing logout after specific conditions are met:

  1. Time out and log user out after 1min inactive
  2. If transacting through a connector, force user to logout after each transaction. Push & pull payments through a connector.

Flaws: If transaction or operation takes longer than 1 min, auto logout may interfere and cause the transaction to fail. Perhaps this is a good thing as we do not want any operation to take longer than a minute.

image

codecov-commenter commented 1 year ago

Codecov Report

Merging #481 (f5b2cb5) into main (30822c2) will decrease coverage by 0.65%. The diff coverage is 23.72%.

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   49.18%   48.53%   -0.66%     
==========================================
  Files         147      148       +1     
  Lines        2324     2382      +58     
  Branches      457      464       +7     
==========================================
+ Hits         1143     1156      +13     
- Misses       1181     1226      +45     
Impacted Files Coverage Δ
web-client/src/app/views/pull/pull.page.ts 25.83% <0.00%> (-0.67%) :arrow_down:
...client/src/environments/environment.bhutan-prod.ts 100.00% <ø> (ø)
...ent/src/environments/environment.bhutan-staging.ts 100.00% <ø> (ø)
...-client/src/environments/environment.palau-prod.ts 100.00% <ø> (ø)
...ient/src/environments/environment.palau-staging.ts 100.00% <ø> (ø)
web-client/src/environments/environment.prod.ts 100.00% <ø> (ø)
web-client/src/environments/environment.staging.ts 100.00% <ø> (ø)
web-client/src/environments/environment.ts 100.00% <ø> (ø)
web-client/src/app/services/auto-logout.service.ts 20.40% <20.40%> (ø)
web-client/src/app/views/pay/pay.page.ts 20.61% <25.00%> (+0.18%) :arrow_up:
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit fedcba006bf2dfcde71f7ce689abb7eca9edffd5
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/639adf834db9f000081eacf1
Deploy Preview https://deploy-preview-481--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.