ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

Quick access Functionality. #500

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Quick access Functionality.

Click up Task

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit eff008bb4886682089279d258b3255691deb2471
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/63c9a9935ce80800088f8395
Deploy Preview https://deploy-preview-500--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #500 (deb2dd6) into main (e6d318c) will decrease coverage by 0.66%. The diff coverage is 29.06%.

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   48.46%   47.81%   -0.66%     
==========================================
  Files         167      172       +5     
  Lines        2548     2633      +85     
  Branches      504      509       +5     
==========================================
+ Hits         1235     1259      +24     
- Misses       1313     1374      +61     
Impacted Files Coverage Δ
...rc/app/views/wallet-access/wallet-access.module.ts 100.00% <ø> (ø)
...client/src/environments/environment.bhutan-prod.ts 100.00% <ø> (ø)
...ent/src/environments/environment.bhutan-staging.ts 100.00% <ø> (ø)
...-client/src/environments/environment.palau-prod.ts 100.00% <ø> (ø)
...ient/src/environments/environment.palau-staging.ts 100.00% <ø> (ø)
web-client/src/environments/environment.prod.ts 100.00% <ø> (ø)
web-client/src/environments/environment.staging.ts 100.00% <ø> (ø)
web-client/src/environments/environment.ts 100.00% <ø> (ø)
...b-client/src/app/state/qAccess/q-access.service.ts 7.14% <7.14%> (ø)
.../components/quick-access/quick-access.component.ts 29.62% <29.62%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

IscoRuta98 commented 1 year ago

If you have a saved address, the interface is a bit confusing. It would be better if, when you clicked anywhere in the box of the saved address, if it just filled in the form with the address. Finding the copy icon wasn't intuitive for me.

Otherwise everything works good.

@sonasi, thanks for the feedback, is the below checkbox suitable? With regards to the interface, perhaps adding a copy button instead? But I'll wait on Bronwynne's input too on this. image