ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

Autofund API Error handling #537

Closed sonasi closed 1 year ago

sonasi commented 1 year ago

Catch ripple transaction errors and return the proper CORS header variables. This gives a 503 "Autofund temporarily unavailable" error instead of a 500 if anything goes wrong with the transaction. This status code's retry functionality could later be leveraged in a future PR.

Remove unnecessary environment.ts variables for the old autofund method.

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging canceled.

Name Link
Latest commit 61751ec50645d205966d2998b1193e0c17d217cb
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/63f92753ef70880008171e77
codecov-commenter commented 1 year ago

Codecov Report

Merging #537 (1b669d0) into main (2300704) will increase coverage by 0.03%. The diff coverage is 10.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   47.09%   47.12%   +0.03%     
==========================================
  Files         172      172              
  Lines        2716     2716              
  Branches      525      527       +2     
==========================================
+ Hits         1279     1280       +1     
+ Misses       1437     1436       -1     
Impacted Files Coverage Δ
web-client/src/app/views/register/register.page.ts 47.27% <ø> (ø)
...client/src/environments/environment.bhutan-prod.ts 100.00% <ø> (ø)
...ent/src/environments/environment.bhutan-staging.ts 100.00% <ø> (ø)
...-client/src/environments/environment.palau-prod.ts 100.00% <ø> (ø)
...ient/src/environments/environment.palau-staging.ts 100.00% <ø> (ø)
web-client/src/environments/environment.prod.ts 100.00% <ø> (ø)
web-client/src/environments/environment.staging.ts 100.00% <ø> (ø)
web-client/src/environments/environment.ts 100.00% <ø> (ø)
web-client/src/app/state/session-xrpl.service.ts 5.69% <10.00%> (+0.63%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.