search

ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

fix(web-client): Error Message on Wrong address #544

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Error Message on Wrong address and/or pin entered

Users who mistype their wallet address into the Open Wallet function are still asked for a pin, and the wallet attempts to open but simply comes up with an error “Unexpected Error Occurred” …. they think this is a technical failure as there is no indication the information the entered was incorrect. We should have better capture and communication to the user that the address input was invalid.

Testing the bug fix

  1. Checkout branch login-error-message.
  2. Launch the Nautilus Wallet App locally.
  3. Login with an invalid address, and the below error message should appear.

image

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit 3427382ebe0cb325e86a9e046b6fba9772fde09a
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/642197aef2fc6100083d0a78
Deploy Preview https://deploy-preview-544--nautilus-wallet-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #544 (3427382) into main (89e5104) will increase coverage by 0.64%. The diff coverage is 76.19%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
+ Coverage   46.74%   47.39%   +0.64%     
==========================================
  Files         172      172              
  Lines        2721     2741      +20     
  Branches      529      527       -2     
==========================================
+ Hits         1272     1299      +27     
+ Misses       1449     1442       -7
Impacted Files Coverage Δ
.../src/app/views/wallet-access/wallet-access.page.ts 86.00% <76.19%> (-7.34%) :arrow_down:

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.