ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

Fix remember address issue & a confirmation dialog box before removing a saved address #545

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Remember Address Issue

When user clicks on ""remember address"", once pin entered, the wallet requests user to enter a nickname and press Ok. If users changes his mind and hits cancel, the wallet is still saved with nickname ""undefined"". In this case, it not only creates an Unknown item in the saved addresses list but duplicates the last entry in the existing saved addresses list where ones already exist. Lastly it allows users to save addresses they already have in their saved addresses which causes confusion and long duplicate lists in the saved addresses.

Remove saved address needs a confirmation dialog box

Current functionality for the removal of saved addresses is to only click the red bin icon on the entry - and it is instantly removed. This can be done far too easily by mistake on a mobile phone, either as the user navigates the screen or tries to copy the saved address (as this requires pressing a button next to delete). Users will heavily depend on their wallet address being in the saved addresses and raise issues when this gets deleted. The functionality should require confirmation through a yes/no dialog box before deleting the entry.

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit e494593ed4cb83a07f27c0bbdd27de249c18419e
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/642363d8db88a3000794f7f1
Deploy Preview https://deploy-preview-545--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.