ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

fix(web-client): wallet nickname pop up #546

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Enter wallet nickname pop up shows page opening in the background

Background

The “Enter Wallet Nickname” dialog box appears on clicking Confirm on the PIN screen, the user then clicks on the text box and starts entering a name and as the app progresses in the background the text box loses focus so the user typing does not work. Note that this is very awkward in Palau where the lag due to internet is much longer (it all happens over many seconds as opposed to 1-2 seconds).

Acceptance Criteria

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit ef3dcc1c96955b103292b64f94ef40a328fe5334
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/6436878d86a0b50008820099
Deploy Preview https://deploy-preview-546--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #546 (2289f98) into main (203613a) will increase coverage by 0.41%. The diff coverage is 62.16%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
+ Coverage   47.28%   47.69%   +0.41%     
==========================================
  Files         172      172              
  Lines        2741     2757      +16     
  Branches      527      527              
==========================================
+ Hits         1296     1315      +19     
+ Misses       1445     1442       -3     
Impacted Files Coverage Δ
...b-client/src/app/state/qAccess/q-access.service.ts 27.45% <56.00%> (+20.30%) :arrow_up:
.../src/app/views/wallet-access/wallet-access.page.ts 83.63% <66.66%> (-2.37%) :arrow_down:
...rc/app/components/pin-entry/pin-entry.component.ts 75.51% <75.00%> (+15.19%) :arrow_up:
web-client/src/app/state/qAccess/q-access.query.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.