search

ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

refactor(web-client): user logging in using quick access. #547

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Background

The need to click a copy icon on saved addresses and then paste the address into the "Enter wallet address" text box above is very fiddly on mobile phones. It would be much more intuitive and easy for users if they could click on the saved address and it either automatically populates the text field, or even better progresses to the Pin entry screen based on that address.

Acceptance criteria

The user can click on the saved address and be taken to the pin entry directly without needing to enter the saved wallet address

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit 20e789e79fce1e8c0b0aca5d3393cba4f044581d
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/644ba4e440fbac0008b1172c
Deploy Preview https://deploy-preview-547--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #547 (821bf61) into main (22e2b7d) will increase coverage by 0.83%. The diff coverage is 26.31%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
+ Coverage   46.30%   47.13%   +0.83%     
==========================================
  Files         173      173              
  Lines        2801     2811      +10     
  Branches      537      538       +1     
==========================================
+ Hits         1297     1325      +28     
+ Misses       1504     1486      -18
Impacted Files Coverage Δ
.../components/quick-access/quick-access.component.ts 32.50% <22.22%> (+2.50%) :arrow_up:
...rc/app/components/pin-entry/pin-entry.component.ts 75.51% <100.00%> (ø)

... and 2 files with indirect coverage changes