ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

Fix invite code bug #553

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

When an invalid code is used, there is no error message for the user. This PR fixes this issue by adding validation error message.

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit 75f59f4467d92509b4f7315e67c9c074cb584131
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/644b90a5443f060008035913
Deploy Preview https://deploy-preview-553--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #553 (75f59f4) into main (56bdf1c) will increase coverage by 0.77%. The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   46.38%   47.16%   +0.77%     
==========================================
  Files         173      173              
  Lines        2796     2801       +5     
  Branches      534      537       +3     
==========================================
+ Hits         1297     1321      +24     
+ Misses       1499     1480      -19     
Impacted Files Coverage Δ
web-client/src/app/services/invite.service.ts 11.11% <0.00%> (-0.89%) :arrow_down:
web-client/src/app/views/register/register.page.ts 41.42% <0.00%> (-1.86%) :arrow_down:

... and 2 files with indirect coverage changes