ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

Fix frontend prompt user to save nickname #555

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Aim of this PR is to fix the following issue: Make sure a user cannot save an empty wallet nickname. They can chose to cancel, and this won't cause duplication in the quick access component. image

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit c418f90bcb8703ec31b612f4b999f3dd067efe29
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/64512dde4e939b0008aeb762
Deploy Preview https://deploy-preview-555--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #555 (c418f90) into main (68d47cf) will decrease coverage by 0.92%. The diff coverage is 14.28%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   47.12%   46.20%   -0.92%     
==========================================
  Files         173      173              
  Lines        2814     2820       +6     
  Branches      539      541       +2     
==========================================
- Hits         1326     1303      -23     
- Misses       1488     1517      +29     
Impacted Files Coverage Δ
...b-client/src/app/state/qAccess/q-access.service.ts 26.31% <14.28%> (-1.14%) :arrow_down:

... and 2 files with indirect coverage changes