ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

refactor(web-client): nickname prompt before login #557

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Background

The enter Wallet Nickname dialog box appears on clicking Confirm on the PIN screen, the user then clicks on the text box and starts entering a name and as the app progresses in the background the text box loses focus so the user typing does not work. Note that this is very awkward in Palau where the lag due to internet is much longer (it all happens over many seconds as opposed to 1-2 seconds).

Acceptance Criteria

Wait for the wallet nickname to be entered before opening the app

Prevent the same wallet from being saved twice. If the wallet address already exists in local storage do not display the save address checkbox to the user again

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit adfd63598f682cccaa70a0b1207c70f69c918959
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/645225f3f86e940007676fd6
Deploy Preview https://deploy-preview-557--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #557 (adfd635) into main (454f165) will increase coverage by 0.35%. The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   46.63%   46.99%   +0.35%     
==========================================
  Files         173      173              
  Lines        2820     2824       +4     
  Branches      541      544       +3     
==========================================
+ Hits         1315     1327      +12     
+ Misses       1505     1497       -8     
Impacted Files Coverage Δ
...b-client/src/app/state/qAccess/q-access.service.ts 24.59% <0.00%> (-1.73%) :arrow_down:
.../src/app/views/wallet-access/wallet-access.page.ts 83.63% <0.00%> (ø)

... and 2 files with indirect coverage changes