feat(web-client): Initial 2FA Frontend

IscoRuta98 commented 1 year ago

Initial Frontend Implementation of Two Factor Authentication.

User story: As a wallet owner I want to complete 2FA on transactions to prevent fraudulent transactions

Background:

As a wallet owner I want to ensure that I can securely transact.

Acceptance Criteria:

User can set up 2FA for transactions with the following options
Set up cell number for 2FA
Set up limits per account for which amounts equal to or exceeding will require 2FA.
Set up limits for payments to specific wallet addresses which will require 2FA.
On making a payment which triggers one of the rules sets as per the above, the wallet owner will receive an OTP and be prompted to enter this in in order to conclude the payment. (pop up)
On changing limits or removing a wallet address the user should be prompted to complete 2FA to complete the action

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name	Link
Latest commit	07c595702fb65fc143b2c6553ed5d0c2afdfbd6b
Latest deploy log	https://app.netlify.com/sites/nautilus-wallet-staging/deploys/646f651253d6cb000868746a
Deploy Preview	https://deploy-preview-569--nautilus-wallet-staging.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #569 (0918599) into main (274278d) will decrease coverage by 1.62%. The diff coverage is 29.51%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   46.92%   45.30%   -1.62%     
==========================================
  Files         173      188      +15     
  Lines        2828     3112     +284     
  Branches      546      589      +43     
==========================================
+ Hits         1327     1410      +83     
- Misses       1501     1702     +201

Impacted Files	Coverage Δ
.../components/quick-access/quick-access.component.ts	`30.23% <0.00%> (-2.27%)`	:arrow_down:
...client/src/app/services/enclave/enclave.service.ts	`68.18% <0.00%> (-4.11%)`	:arrow_down:
...b-client/src/app/state/qAccess/q-access.service.ts	`23.33% <ø> (-1.26%)`	:arrow_down:
web-client/src/app/state/session.service.ts	`6.08% <0.00%> (-0.22%)`	:arrow_down:
...b-client/src/app/utils/notification/swal-helper.ts	`33.33% <0.00%> (-66.67%)`	:arrow_down:
web-client/src/app/views/pay/pay.page.ts	`18.54% <11.11%> (-2.08%)`	:arrow_down:
.../app/state/otpRecipients/otp-recipients.service.ts	`12.19% <12.19%> (ø)`
...ient/src/app/state/otpLimits/otp-limits.service.ts	`20.00% <20.00%> (ø)`
...client/src/app/state/otpLimits/otp-limits.query.ts	`30.00% <30.00%> (ø)`
web-client/src/app/services/otp-prompt.service.ts	`30.76% <30.76%> (ø)`
... and 13 more

billguo99 commented 1 year ago

My OTP recipient trigger for wallet address rhLD4o8kLSqks53RtZQC3fUQFV5h6GvXXK:

However, it's displaying the same one twice instead of two different ones:

billguo99 commented 1 year ago

Yeah there's still something buggy about the wallet addresses. When I add two wallet addresses in a row, it doesn't show two has been added.

ntls-io / nautilus-wallet