Closed IscoRuta98 closed 1 year ago
Name | Link |
---|---|
Latest commit | 2e587c1e08ee33acf4e011df828cfd1b2f51c436 |
Latest deploy log | https://app.netlify.com/sites/nautilus-wallet-staging/deploys/648071d16bcfd20007f89a5e |
Deploy Preview | https://deploy-preview-575--nautilus-wallet-staging.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Merging #575 (2e587c1) into main (d37ad4c) will decrease coverage by
0.14%
. The diff coverage is2.04%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #575 +/- ##
==========================================
- Coverage 45.28% 45.15% -0.14%
==========================================
Files 189 189
Lines 3109 3127 +18
Branches 616 618 +2
==========================================
+ Hits 1408 1412 +4
- Misses 1701 1715 +14
Impacted Files | Coverage Δ | |
---|---|---|
...b-client/src/app/utils/notification/swal-helper.ts | 20.00% <0.00%> (-13.34%) |
:arrow_down: |
...b-client/src/app/views/pin-reset/pin-reset.page.ts | 20.00% <2.22%> (-3.92%) |
:arrow_down: |
Remove the logs please
onSubmit
function is quite big... can you break it down to smaller functions?
@jongbonga, I've broken down the onSubmit()
function to smaller functions.
Bug: When user gets incorrect answers to security questions, and wants to try again, the submit button has been disabled. Fix: Submit button is disabled when answers are checked, but enabled when user wants to submit attempts to security questions.
Bug: User can enter an empty PIN as their new PIN. Fix: Add validation to make sure new PIN is valid.