ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

refactor(web-client): remove address list if empty #576

Closed jongbonga closed 1 year ago

jongbonga commented 1 year ago

Refactor some of the logic in the store and removed unnecessary code

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit f087861ae873c68323f7cb96613a56fd70a2a51d
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/6475b7daefb50300084dda22
Deploy Preview https://deploy-preview-576--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #576 (f087861) into main (211a0b0) will decrease coverage by 1.40%. The diff coverage is 30.22%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   46.96%   45.56%   -1.40%     
==========================================
  Files         173      188      +15     
  Lines        2832     3081     +249     
  Branches      547      590      +43     
==========================================
+ Hits         1330     1404      +74     
- Misses       1502     1677     +175     
Impacted Files Coverage Δ
.../components/quick-access/quick-access.component.ts 25.00% <0.00%> (-7.50%) :arrow_down:
...client/src/app/services/enclave/enclave.service.ts 68.18% <0.00%> (-4.11%) :arrow_down:
web-client/src/app/state/qAccess/q-access.model.ts 100.00% <ø> (ø)
web-client/src/app/state/qAccess/q-access.query.ts 100.00% <ø> (ø)
web-client/src/app/state/qAccess/q-access.store.ts 100.00% <ø> (ø)
web-client/src/app/state/session.service.ts 6.08% <0.00%> (-0.22%) :arrow_down:
...b-client/src/app/utils/notification/swal-helper.ts 33.33% <0.00%> (-66.67%) :arrow_down:
web-client/src/app/views/pay/pay.page.ts 18.54% <11.11%> (-2.08%) :arrow_down:
.../app/state/otpRecipients/otp-recipients.service.ts 12.19% <12.19%> (ø)
...ient/src/app/state/otpLimits/otp-limits.service.ts 20.00% <20.00%> (ø)
... and 18 more