ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

feat(web-client): add bookmarked name to transactions #579

Closed jongbonga closed 1 year ago

jongbonga commented 1 year ago

Show receiver name on pay & sender name on pull if the address is found on the bookmark list

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit e69ea4ffd5d8f313ed4405954a3ccf94c031fb7c
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/6478794872d24300081daf23
Deploy Preview https://deploy-preview-579--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

billguo99 commented 1 year ago

All looks good, just need to run prettier: npm run format

jongbonga commented 1 year ago

@IscoRuta98 @billguo99 Done.

codecov-commenter commented 1 year ago

Codecov Report

Merging #579 (6ed3def) into main (211a0b0) will decrease coverage by 1.53%. The diff coverage is 30.76%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   46.96%   45.43%   -1.53%     
==========================================
  Files         173      188      +15     
  Lines        2832     3088     +256     
  Branches      547      593      +46     
==========================================
+ Hits         1330     1403      +73     
- Misses       1502     1685     +183     
Impacted Files Coverage Δ
.../components/quick-access/quick-access.component.ts 25.00% <0.00%> (-7.50%) :arrow_down:
...client/src/app/services/enclave/enclave.service.ts 68.18% <0.00%> (-4.11%) :arrow_down:
web-client/src/app/state/qAccess/q-access.model.ts 100.00% <ø> (ø)
web-client/src/app/state/qAccess/q-access.query.ts 100.00% <ø> (ø)
web-client/src/app/state/qAccess/q-access.store.ts 100.00% <ø> (ø)
web-client/src/app/state/session.service.ts 6.08% <0.00%> (-0.22%) :arrow_down:
...b-client/src/app/utils/notification/swal-helper.ts 33.33% <0.00%> (-66.67%) :arrow_down:
web-client/src/app/views/pay/pay.page.ts 18.54% <11.11%> (-2.08%) :arrow_down:
.../app/state/otpRecipients/otp-recipients.service.ts 12.19% <12.19%> (ø)
...ient/src/app/state/otpLimits/otp-limits.service.ts 20.00% <20.00%> (ø)
... and 20 more