search

ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

fix(web-client): check wallet id on scan success #581

Closed jongbonga closed 1 year ago

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit 1a8b4ab57cbfd4582a1647b0fb32d3d7f85c0fd6
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/6478832a09089400087d7777
Deploy Preview https://deploy-preview-581--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #581 (1a8b4ab) into main (7f43b47) will increase coverage by 0.00%. The diff coverage is 66.66%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #581   +/-   ##
=======================================
  Coverage   44.94%   44.94%           
=======================================
  Files         188      188           
  Lines        3097     3099    +2     
  Branches      596      597    +1     
=======================================
+ Hits         1392     1393    +1     
- Misses       1705     1706    +1
Impacted Files Coverage Δ
.../src/app/views/wallet-access/wallet-access.page.ts 82.75% <66.66%> (-1.17%) :arrow_down:
billguo99 commented 1 year ago

rebase with main :)

billguo99 commented 1 year ago

Where do you access the scan page to scan a QR code? I clicked "open wallet" but it doesn't give option to scan QR code.

jongbonga commented 1 year ago

This PR addresses something else. If you are running the code locally, you can remove hasCamera on the wallet access template to test

billguo99 commented 1 year ago

This PR addresses something else. If you are running the code locally, you can remove hasCamera on the wallet access template to test

What does this PR address? Is this only for mobile app? Which file should I remove hasCamera?

billguo99 commented 1 year ago

I removed hasCamera ng-container block and Access wallet with QR code option worked. I don't have a wallet address QR code to test so that's as far as I've tested. The option comes up and the camera webcam works.