ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

fix(web-client): Fix 2FA bugs #583

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

The aim of this PR is to address the following bugs:

  1. Wallet address input for OTP recipients is accepting any text input. It should only accept valid addresses.
  2. Update OTP cell number does not work.
  3. Current limits aren't showing. User should be able to see current limit for a given account.
  4. 2FA needs to fire when changing any triggers.
netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit f7e9e684a1ce86128befebb64f86e98bcb2443fa
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/648077ec245f8200085ae86d
Deploy Preview https://deploy-preview-583--nautilus-wallet-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #583 (f7e9e68) into main (7349a04) will decrease coverage by 1.60%. The diff coverage is 7.89%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   45.15%   43.56%   -1.60%     
==========================================
  Files         189      189              
  Lines        3127     3191      +64     
  Branches      602      641      +39     
==========================================
- Hits         1412     1390      -22     
- Misses       1715     1801      +86     
Impacted Files Coverage Ξ”
web-client/src/app/services/otp-prompt.service.ts 16.12% <0.00%> (-14.65%) :arrow_down:
.../app/state/otpRecipients/otp-recipients.service.ts 12.50% <ΓΈ> (+0.30%) :arrow_up:
web-client/src/app/state/session.service.ts 5.88% <0.00%> (-0.21%) :arrow_down:
web-client/src/app/views/triggers/triggers.page.ts 20.00% <5.08%> (-12.26%) :arrow_down:
...r-authentication/two-factor-authentication.page.ts 46.34% <75.00%> (+1.60%) :arrow_up:

... and 2 files with indirect coverage changes