ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

fix(web-client): Prevent auto-logout #590

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

This PR aims to fix the following bug: Prevent auto-logout when an error occurs.

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit fa5d3c2349c91e5fdbeac074b76e17c8917874ff
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/648845928668260008d5e657
Deploy Preview https://deploy-preview-590--nautilus-wallet-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov-commenter commented 1 year ago

Codecov Report

Merging #590 (2c53b20) into main (4fcd9e9) will increase coverage by 1.37%. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
+ Coverage   43.43%   44.80%   +1.37%     
==========================================
  Files         189      189              
  Lines        3207     3207              
  Branches      644      644              
==========================================
+ Hits         1393     1437      +44     
+ Misses       1814     1770      -44     
Impacted Files Coverage Δ
web-client/src/app/state/session-xrpl.service.ts 5.69% <0.00%> (ø)
...lient/src/app/utils/errors/global-error-handler.ts 6.25% <0.00%> (ø)
web-client/src/app/views/pull/pull.page.ts 25.20% <0.00%> (ø)
web-client/src/environments/environment.ts 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

IscoRuta98 commented 1 year ago

Do you know that back() just navigate one page back right?

Why do you navigate back on global error?

Yes, I do. The Acceptance Criteria of the task states that the user should be returned back to the previous page.