ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

fix(web-client): wallet address validator for bookmark. #592

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

The aim of this PR is to resolve the following issue: PAY: Unsupported Address Screen.

A wallet address is first checked for its validity before saving a new bookmark. That way, any payments made via bookmarks page will consist of valid addresses.

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging canceled.

Name Link
Latest commit c95834150cd4ac92c0222d4f7346c0ee27dd97de
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/64916c487d70770008e2c4fa
codecov-commenter commented 1 year ago

Codecov Report

Merging #592 (80ef096) into main (b5b7b30) will increase coverage by 0.33%. The diff coverage is 18.18%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
+ Coverage   43.37%   43.70%   +0.33%     
==========================================
  Files         189      189              
  Lines        3214     3219       +5     
  Branches      646      647       +1     
==========================================
+ Hits         1394     1407      +13     
+ Misses       1820     1812       -8     
Impacted Files Coverage Δ
...b-client/src/app/utils/notification/swal-helper.ts 16.66% <0.00%> (-3.34%) :arrow_down:
web-client/src/app/views/triggers/triggers.page.ts 20.79% <0.00%> (+0.79%) :arrow_up:
web-client/src/app/utils/validators.ts 46.66% <14.28%> (-28.34%) :arrow_down:
.../components/new-bookmark/new-bookmark.component.ts 37.50% <40.00%> (-0.97%) :arrow_down:

... and 1 file with indirect coverage changes