search

ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

fix(backend-services): change date values to be calculated from unix timestamps for recurring payments #599

Closed billguo99 closed 1 year ago

billguo99 commented 1 year ago

date.ToOrdinal() method in Python is not compatible or very difficult to know what the implementation of the function is.

So I opted to just use int value of unix timestamps instead.

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging canceled.

Name Link
Latest commit 1ea48a9e909c352a7bab8c1b12a84a9d3f4db47e
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/64a3cd78b296a80008bcd20b
codecov-commenter commented 1 year ago

Codecov Report

Merging #599 (1ea48a9) into main (a0b4f88) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #599   +/-   ##
=======================================
  Coverage   44.08%   44.08%           
=======================================
  Files         189      189           
  Lines        3219     3219           
  Branches      647      647           
=======================================
  Hits         1419     1419           
  Misses       1800     1800
billguo99 commented 1 year ago

Actually it's fine, I found the implementation in the Python docs - https://github.com/python/cpython/blob/3cc5c4a073d63534e45fc08d7906a77180e8aaa3/Lib/datetime.py#L63