search

ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

fix(web-client): Improve error msg for pull pay #601

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Aim of this PR is to improve error messages for Pull payments, according to the below: (Related to Issuw NW-107)

Pulling Money from your own wallet

Pulling Money from Empty Wallet

Pull payment Enter invalid Wallet Address

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit 070cf36cbb5d8a09db69080283686e5c9cb7c0fa
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/64b54c73cf50a6000841d95f
Deploy Preview https://deploy-preview-601--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-commenter commented 1 year ago

Codecov Report

Merging #601 (c57387f) into main (8d2286e) will decrease coverage by 0.17%. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   43.23%   43.07%   -0.17%     
==========================================
  Files         201      201              
  Lines        3430     3443      +13     
  Branches      692      696       +4     
==========================================
  Hits         1483     1483              
- Misses       1947     1960      +13
Impacted Files Coverage Δ
...b-client/src/app/utils/notification/swal-helper.ts 12.50% <0.00%> (-4.17%) :arrow_down:
web-client/src/app/views/pay/pay.page.ts 18.11% <0.00%> (-0.44%) :arrow_down:
web-client/src/app/views/pull/pull.page.ts 24.60% <0.00%> (-0.61%) :arrow_down:
...rc/app/views/transfer-funds/transfer-funds.page.ts 27.90% <0.00%> (-2.10%) :arrow_down:
billguo99 commented 1 year ago

Pulling Money from your own wallet

* Error Message not user friendly

I'm assuming this meant to be "Sending money from your own wallet"?

billguo99 commented 1 year ago

Have you tested the notifications?