ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

refactor(web-client): improve error messages. #607

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Aim of this PR

Improve ripple-related transaction error messages for the user. This PR addresses issues: NW-107 & NW-219

Various scenarios to test for in this PR:

  1. Sending funds to a deleted wallet. When user tries to send funds to a deleted wallet, a notification should popup, informing the user that they cannot send funds to a wallet that has been deleted.

  2. Pulling funds from a deleted wallet. When user attempts to pull funds wallet from a deleted wallet; a notification should let them know that they should not be able to do so.

  3. Pulling funds from a wallet that has insufficient tokens or has not opted into the currency. When user attempts to pull funds wallet from a wallet that has not opted into the token (e.g. FOO) or insufficient tokens; a notification should let them know that this is not possible.

  4. Deleting a newly created wallet When a user wants to delete a new wallet that they created, this is sometimes not possible, as the address has not been validated yet on the blockchain. Therefore, a notification should appear that tells the user to try again later.

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit f02d369d7a85a4c6c8155e8a0debea3a84b7a0b3
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/64bebeab15013900080d8aa2
Deploy Preview https://deploy-preview-607--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.