ntls-io / nautilus-wallet

Nautilus Wallet

GNU Affero General Public License v3.0

8 stars 4 forks source link

fix(web-client): QR failure sending money. #608

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Aim of this PR:

Addresses the following issue: Error message displayed when scanning an invalid QR code on Send Money >>Scan a QR Code needs to be user friendly (Updated from just "Unexpected Error Occurred" to “The Wallet address you have scanned is invalid“)

This PR addresses part of issue NW-107

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name	Link
Latest commit	b4d00f5157913e08c3260ddcf649d567598d125d
Latest deploy log	https://app.netlify.com/sites/nautilus-wallet-staging/deploys/64cb4de403ecda00087fdb16
Deploy Preview	https://deploy-preview-608--nautilus-wallet-staging.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

billguo99 commented 1 year ago

I don't see how the changes you made would show: “The Wallet address you have scanned is invalid“

codecov-commenter commented 1 year ago

Codecov Report

Merging #608 (bdc2d27) into main (08f1224) will decrease coverage by 0.04%. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   42.52%   42.49%   -0.04%     
==========================================
  Files         201      201              
  Lines        3487     3490       +3     
  Branches      685      686       +1     
==========================================
  Hits         1483     1483              
- Misses       2004     2007       +3

Files Changed	Coverage Δ
...lient/src/app/utils/errors/global-error-handler.ts	`5.26% <0.00%> (-0.99%)`	:arrow_down: