ntls-io / nautilus-wallet

Nautilus Wallet
GNU Affero General Public License v3.0
8 stars 4 forks source link

fix(web-client): diasble autologout in send & pull pay #611

Closed IscoRuta98 closed 1 year ago

IscoRuta98 commented 1 year ago

Aim of this PR is to disable Auto Logout when user is confirming transactions (for pull and pay payments).

netlify[bot] commented 1 year ago

Deploy Preview for nautilus-wallet-staging ready!

Name Link
Latest commit baf751488b7a9ead53fe5d8895b43185cab6181e
Latest deploy log https://app.netlify.com/sites/nautilus-wallet-staging/deploys/64cb56bcc0b9ba00082ca2cf
Deploy Preview https://deploy-preview-611--nautilus-wallet-staging.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov-commenter commented 1 year ago

Codecov Report

Merging #611 (baf7514) into main (58b5197) will decrease coverage by 0.19%. The diff coverage is 17.64%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   42.49%   42.31%   -0.19%     
==========================================
  Files         201      201              
  Lines        3490     3505      +15     
  Branches      686      686              
==========================================
  Hits         1483     1483              
- Misses       2007     2022      +15     
Files Changed Coverage Δ
web-client/src/app/services/auto-logout.service.ts 20.37% <16.66%> (-0.04%) :arrow_down:
web-client/src/app/views/pull/pull.page.ts 22.37% <16.66%> (-0.09%) :arrow_down:
web-client/src/app/views/pay/pay.page.ts 17.39% <20.00%> (+0.09%) :arrow_up:

... and 1 file with indirect coverage changes

billguo99 commented 1 year ago

Have you tested this locally?

IscoRuta98 commented 1 year ago

Have you tested this locally?

Yes I have. Have you been encountering errors?