search

ntno / mkdocs-terminal

monospace theme for MkDocs
https://ntno.github.io/mkdocs-terminal/
MIT License
117 stars 5 forks source link

navigation.side.hide feature leaves an empty space on the side #129

Closed ntno closed 1 year ago

ntno commented 1 year ago 
          Using navigation.side.hide feature leaves an empty space on the side. Would be nice to get rid of it.

Originally posted by @jpasikainen in https://github.com/ntno/mkdocs-terminal/issues/21#issuecomment-1492078861

Hello @jpasikainen Can you please take a look at the following screenshots and let me know if this is the expected behavior of your suggestion?

before

navigation.side.hide is enabled but main content is to the right of the "Terminal for MkDocs" site title:

with-side-nav-hide

proposed change

when navigation.side.hide is enabled, main content should begin directly beneath the "Terminal for MkDocs" site title:

proposed-change
ntno commented 1 year ago

hi @jpasikainen please check out the screenshots on this PR and let me know what you think: https://github.com/ntno/mkdocs-terminal/pull/130 thanks for the suggestion!

jpasikainen commented 1 year ago

hi @jpasikainen please check out the screenshots on this PR and let me know what you think: https://github.com/ntno/mkdocs-terminal/pull/130 thanks for the suggestion!

Yeah this is exactly what I meant. Looks good!

ntno commented 1 year ago

great! published change in version 4.4.0