ntno / mkdocs-terminal

monospace theme for MkDocs
https://ntno.github.io/mkdocs-terminal/
MIT License
117 stars 5 forks source link

Upgrade to terminal 0.7.4 #143

Closed ntno closed 2 months ago

ntno commented 2 months ago

point to terminal.css version 0.7.4 (currently at 0.7.2)

would make progress on #144

Description

the "Terminal for MkDocs" theme is currently behind the terminal.css upstream. this change updates terminal/css/terminal.css to point to version 0.7.4 and makes a few updates to terminal/css/theme.css to maintain current behavior.

Changes

Testing

spun up local documentation server in Firefox and spot checked

Checklist

ntno commented 2 months ago

upgrade issue - code blocks background color not filling the entire block:

local with 0.7.4

Screen Shot 2024-08-07 at 6 41 10 PM

live with 0.7.2

Screen Shot 2024-08-07 at 6 41 21 PM

fixed with override in theme.css

/* use the `code-bg-color` for `code` blocks */

pre code {
    background-color: var(--code-bg-color);
}
ntno commented 2 months ago

paragraph tag bug fix

<p></p> color should be font-color not global-font-color

ntno commented 2 months ago

fix font color in markdown-extended figcaption

when a user takes advantage of the "markdown in html" feature, their caption text is inserted inside of a <p> tag (inside the regular <figcaption> tag). after the fix mentioned above, the <p> tag will use font-color. however it makes more sense for <p> tags inside a <figcaption> to use the secondary color.

fixed in theme.css

/* set figcaption paragraph text to the secondary color.  this occurs when using markdown inside the figcaption */

figure>figcaption>p {
    color: var(--secondary-color);
}