ntntnlstdnt / codelab-external-assets

https://github.com
0 stars 0 forks source link

Code Lab Feedback #1

Open ntntnlstdnt opened 9 years ago

ntntnlstdnt commented 9 years ago

Hey @egillespie, can you take a look at this? It's hosted here and meets the following project criteria:

egillespie commented 9 years ago

Beautiful! :shipit:

The W3C Markup Validator doesn't warn about using apostrophes (') and spaces in HTML attributes but the more typical convention is to use quotes (") and no spaces around the equal sign in your HTML attributes.

For example:

<p id= 'sport'></p> Valid, but looks weird.
<p id="sport"></p>  Looks good!