Code Lab Feedback

[ntntnlstdnt]

Hey @chrisvfritz, can you take a look at this? It's hosted here and meets the following project criteria:

• [x] The root of your site (/) has a form to collect information that will be embedded in the dating profile
• [x] Submitting the form at the root of the site creates a new dating profile at /profile
• [x] One of the form inputs takes the URL of an image to be displayed on the generated profile
• [x] Any CSS or JavaScript is embedded in the page with a style or script element (we'll learn about including other files in a later lesson)
• x For an added challenge, use the free Formspree service to generate a contact form on the profile page, so that interested parties have a way of getting in touch with the creator of the profile

[chrisvfritz]

I see a few things that could be fixed here:

First, the image always shows in 100x150 pixels, no matter what the actual aspect ratio of the picture is. To fix this, I would remove the width="100" and "height="150" from your img tag and instead specify with CSS something like this:

img.profile-pic {
  max-width: 100px;
}

That will make sure that the image doesn't grow beyond 100 pixels wide and allows the height to be dynamic, so it will always have the correct aspect ratio!

Second, while the data in the profile technically shows up on the page, there's no context to let us know what any of this information means - it's just bullet points. This isn't something you have to change, as it's technically correct, but if you'd like, I would add a little more context.

[chrisvfritz]

Almost perfect now! You included the CSS for img.profile-pic, but isn't a profile-pic class on your img element, so that CSS is not applying. Fix that and it'll be ship-worthy! :smiley:

[ntntnlstdnt]

I have made the corrections and improved the indentation.

[chrisvfritz]

Looking good! :shipit: