search

ntnu-arl / gbplanner_ros

Graph-based Exploration Planner for Subterranean Environments
BSD 3-Clause "New" or "Revised" License
667 stars 152 forks source link

added publisher for m100 velodyne points for melodic #10

Closed preetijain7681 closed 3 years ago

MihirDharmadhikari commented 3 years ago

Hello, Thank you very much this PR. Can you please change the /m100/velodyne_points to /$(arg robot_name)/velodyne_points. This will make sure that the namespace in which the robot is launched is same as that of the pointlcoud topic subscribed by gbplanner_node.

preetijain7681 commented 3 years ago

Yes sure.

On Sat, 26 Jun 2021, 12:32 am Mihir Dharmadhikari, @.***> wrote:

Hello, Thank you very much this PR. Can you please change the /m100/velodyne_points to /$(arg robot_name)/velodyne_points. This will make sure that the namespace in which the robot is launched is same as that of the pointlcoud topic subscribed by gbplanner_node.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ntnu-arl/gbplanner_ros/pull/10#issuecomment-868772774, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQBG5AODHHUAR3SXGAOEAHTTUTHGDANCNFSM47HRP5VQ .

MihirDharmadhikari commented 3 years ago

I went ahead and made this change as it was pending for quite some time.

preetijain7681 commented 3 years ago

Thank you.

On Tue, 13 Jul 2021 at 06:37, Mihir Dharmadhikari @.***> wrote:

I went ahead and made this change as it was pending for quite some time.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ntnu-arl/gbplanner_ros/pull/10#issuecomment-878698991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQBG5AO5FIJ37ITECZYK7A3TXOGUVANCNFSM47HRP5VQ .