Open kikuomax opened 10 months ago
[like] Wesley Ford reacted to your message:
From: Kikuo Emoto @.> Sent: Tuesday, October 8, 2024 2:57:01 PM To: ntohq/buefy-next @.> Cc: Wesley Ford @.>; Mention @.> Subject: Re: [ntohq/buefy-next] Migrate to TypeScript (Issue #151)
I claim datetimepicker.
— Reply to this email directly, view it on GitHubhttps://github.com/ntohq/buefy-next/issues/151#issuecomment-2400088174, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACYRFOCWYMERQJUFVLETZHLZ2PXD3AVCNFSM6AAAAABAARAEA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBQGA4DQMJXGQ. You are receiving this because you were mentioned.Message ID: @.***>
I claim slider
.
I claim skeleton
.
I claim sidebar
.
I claim collapse
.
You all are on fire! 🔥 Thank you for all you do.
You all are on fire! 🔥 Thank you for all you do.
Thanks for the encouragement 😎 @kikuomax is killing it 🔥
I claim breadcrumb
.
I claim ConfigComponent.js
.
@wesdevpro I am planning how to release the migration results to the dev
branch. Since the commit history on the migrate-to-typescript
branch is messy, I would like to rebase it and roll out components to the dev
branch one by one. The order of the roll-out would matter. We would have to start from components that have no dependencies (Tier 0) and then roll out components that depend only on Tier 0 (Tier 1). We would continue this with Tier 2, 3, and so on. By following the right order, we would be able to make sure the dev
branch always passes tests and type checks during the roll-out.
To determine the order I wrote a script to analyze dependencies in the package, which you can find in the migrate-to-typescript-tier-analysis
branch. You can download the analysis results, JSON file, from the top description of this issue.
components to the
dev
branch one by one
This sounds like a great plan to me 💯
jestVitest*.d.ts
) and rollup (buefy.d.ts
)for development that directly includesrunningpackages/buefy-next/src
vite
does not seem to requiretsconfig.json
. Vite clearly states that it won't perform typechecking.dev
branch (Download the tier analysis results as JSON)dev
branch (Download the tier analysis results as JSON)