Closed kikuomax closed 8 months ago
ProviderParentMixin
expects children mixing in InjectedChildMixin
. Users of InjectedChildMixin
:
CarouselItem
: no value
DropdownItem
: value
: [String, Number, Boolean, Object, Array, Function]
ProgressBar
: value
: Number
TabbedChildMixin
: value
: String
Used by:
StepItem
TabItem
I think ProgressBar
should stop using InjectedChildMixin
because its parent Progress
does not use any functionalities of ProviderParentMixin
. Providing Progress
instance to ProgressBar
is sufficient.
DropdownItem
neither has to use InjectedChildMixin
because its parent Dropdown
does not use any functionalities of ProviderParentMixin
. Providing Dropdown
instance to DropdownItem
is sufficient.
_unregisterItem
won't work for CarouselItem
due to missing value
.
Overview of the problem
Buefy version: [0.1.2] Vuejs version: [3.x] OS/Browser: should not matter
Description
See https://github.com/ntohq/buefy-next/blob/20675f127c13ecf216e457d49c5d34e2d7516005/packages/buefy-next/src/utils/ProviderParentMixin.js#L37-L39
Steps to reproduce
Expected behavior
_unregisterItem
should work if child items lackvalue
.Actual behavior
_untegisterItem
won't work if child items lackvalue
.