search

ntohq / buefy-next

Lightweight UI components for Vue.js (Vue3) based on Bulma
https://v3.buefy.org
MIT License
107 stars 10 forks source link

[Select] Meaningless && chaining of `checkHtml5Validity` after `$emit` #271

Open kikuomax opened 1 month ago

kikuomax commented 1 month ago

Since $emit is supposed to return nothing (void or undefined), checkHtml5Validity chained with && won't be called.

https://github.com/ntohq/buefy-next/blob/185589fbced9100d05c84760a7e4eed6dee53da7/packages/buefy-next/src/components/select/Select.vue#L15

kikuomax commented 1 month ago

Due to this commit, Datepicker and Input had the same issue but they were fixed afterward by replacing the event handler with onBlur provided by the FormElementMixin. Do the same for Select.

kikuomax commented 1 month ago

Btw, TypeScript won't tolerate this issue.