Closed tomviner closed 8 years ago
@tomviner this is great stuff! I've had a look around your changes but will need a bit more time to look in more detail. Put simply, I think this is wonderful but I need to update the docs as per your instructions and make some tox related changes before merging into master. Shouldn't take too long, although it ain't gonna happen today.
Thank you! :-)
OK... I fixed a couple of niggles and merged. It works! Yay! Many many thanks for the contribution @tomviner.
Great!
Fix for https://github.com/ntoll/uflash/issues/18 Flash multiple microbits at once
The
target
argument can now occur any number of times.i.e.
On Linux this allows shell expansions like:
or
Note: uflash does not receive (and cannot deal with) strings like
/media/tom/MICROBIT*
, rather shell expansion takes place, so the actual args passed into the script are/media/tom/MICROBIT /media/tom/MICROBIT1
.Windows doesn't do shell expansion, and even the
glob
module cannot reference multiple volumes, i.e.glob.glob('*:\\MICROBIT')
never matches anything. So on Windows, one must pass n paths for n microbits. And the docs update shows just this - no*
or{}
.Full list of changes:
mock.mock_open
rather than a load of__enter__
__exit__
mocking/
v\
make pyflakes / pep8
commands are broken btw - I couldn't workout how to fix them without just listing the files we want, which is what I've done intox.ini
)Happy to alter / take any of these changes out, if they don't seem appropriate. Everything is in separate commits.
If you'd like Appveyor to run the tests on Windows automatically, I can add that too (in a separate PR).