Remove unnecessary fs_name_buf & move inline function definition to the

ntoll / uflash

A module and command to easily flash Python onto the BBC's micro:bit device.

http://micropython.org/

MIT License

101 stars 27 forks source link

Remove unnecessary fs_name_buf & move inline function definition to the #3

Closed funkyHat closed 8 years ago

funkyHat commented 8 years ago

top level

Removed unnecessary buffer creation.

I also thought it made more sense for the function definition to be at the top level now. Though I'm not 100% happy with the name. Maybe it should be win_get_volume_name? (that pushes the if on line 127 onto 2 lines though, not that that should matter more than having a sensible name...)

What do you think?

ntoll commented 8 years ago

Hi @funkyHat - thanks for this, I took your refactor and refactorered it further in commit 493fef31ad2d951336ecdaa63538f38564996371.

I prefer the windows specific function to be defined inline since it's not used anywhere else but in that code branch. That's just me being opinionated though... ;-)

Season's greetings!

funkyHat commented 8 years ago

That's cool. I was a bit conflicted on that myself in any case :)