Make it easier to integrate uflash with external tools

ntoll / uflash

A module and command to easily flash Python onto the BBC's micro:bit device.

http://micropython.org/

MIT License

101 stars 27 forks source link

Make it easier to integrate uflash with external tools #40

Closed Lexicality closed 6 years ago

Lexicality commented 6 years ago

I noticed a couple of problems while trying to do just this at the PyCon UK 2017 code sprint. This PR should fix all my issues 🙂

Lexicality commented 6 years ago

@ntol Fixed the tests. I can't run make check on windows (with a virtualenv full of .py files) but I think everything passes

ntoll commented 6 years ago

Hi, we're missing test coverage:

tests/test_uflash.py .............................................

----------- coverage: platform linux, python 3.5.3-final-0 -----------
Name        Stmts   Miss  Cover   Missing
-----------------------------------------
uflash.py     195     10    95%   71, 373-377, 385-389, 402

It was 100% ;-)

Lexicality commented 6 years ago

fie - it was only 100% because of that all-encompassing print statement :unamused:

Lexicality commented 6 years ago

Fixed

ntoll commented 6 years ago

Thank you!