search

ntoll / uflash

A module and command to easily flash Python onto the BBC's micro:bit device.
http://micropython.org/
MIT License
106 stars 27 forks source link

Added keepname argument and used filename in output message #49

Closed ScottDWebster closed 6 years ago

ScottDWebster commented 6 years ago

I added a new command line argument (-k, --keepname) to preserve the root filename of the python script. I modified the output message to use the input filename instead of "Python" when path_to_python exists. I updated the documentation to reflect the above changes. I added keepname related tests. Let me know if my tests make sense and/or are sufficient.

ntoll commented 6 years ago

Hi, umm.... you've added a whole bunch of files that are not part of this project. Please remove them from the PR. Thanks! :-)

ScottDWebster commented 6 years ago

Oops, sorry. I have no idea what happened, but somehow a number of pdf files got generated in the directory. At some point, git warned of untracked files and I added them without checking what they were. They're all gone now.

ScottDWebster commented 6 years ago

I've created a new script called hexify to allow for multiple input files (it loads uflash as a module). Now I'm thinking that maybe keepname should be removed from the command line arguments of uflash and just left as an argument to flash(). My hexify script always sets keepname to true. It might be less confusing to have the functions of flashing to the microbit (uflash) vs. generating hex files on the local filesystem (hexify) completely separated. What do you think?

ScottDWebster commented 6 years ago

Use my other pull request instead. I'll close this one.