search

ntoll / uflash

A module and command to easily flash Python onto the BBC's micro:bit device.
http://micropython.org/
MIT License
101 stars 27 forks source link

Alternate pull request #50

Closed ScottDWebster closed 6 years ago

ScottDWebster commented 6 years ago

I've done further work and thus created an alternate pull request.

I wanted to add multiple input file support but it seemed that it would be quite awkward to try to shoehorn it into uflash.py so I decided to split out the functionality for creating .hex files on the local filesystem into a separate command & .py file. It seems that could also be accomplished with one .py file by specifying another entry point in setup.py but hopefully this is acceptable. I called the new command "hexify." I know you used the name "hexlify" as a function name but (no offense, but) the L in that word makes no sense to me. I think that most people at a quick glance would read it as "hexify" anyway. If "hexify" is not an acceptable name, then I suggest "mkhex" or "py2hex" as alternative names.

I tried to be as complete as possible though it's possible I might have gone farther than you wished. Pep8 kept vomiting warning messages all over the screen about pep8 being deprecated and pycodestyle preferred, so I updated everything to use pycodestyle instead, I added W504 (line break after binary operator) to the exclusions list.

I think I've covered everything except updating CHANGES.rst, but please sanity check my work.

ScottDWebster commented 6 years ago

I noticed that you had made a 1.1.3 release since I began working on this so I did a rebase. I had also changed to running pycodestyle instead of pep8, but I had also changed the name of the make target. When I noticed that you hadn't, I backed out my changes.