Closed 1715173329 closed 2 years ago
Merging #1036 (7c7072f) into dev (ba8855f) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## dev #1036 +/- ##
=======================================
Coverage 20.74% 20.74%
=======================================
Files 47 47
Lines 8447 8447
=======================================
Hits 1752 1752
Misses 6695 6695
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ba8855f...7c7072f. Read the comment docs.
I probably could have been more verbose when I wrote that TODO, but I was copying from an earlier file which specifically linked this against the static version and intended it to be a reminder to revisit, which you have done!
Thanks!
This is a only exception while all other libraries are dynamically linked.
The "TODO" does not make any sense as libcap provides both dynamic and static libraries. There is not reason to explain why it needs to be statically linked 'especially' as dynamic linking works very well. Then just make it dynamically-linked by default, which also matches the behaviour on autotools.
Compiled and tested on aarch64, no errors found.