Closed hamishcoleman closed 1 year ago
Base: 20.74% // Head: 20.74% // No change to project coverage :thumbsup:
Coverage data is based on head (
4322854
) compared to base (06c489f
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Nowadays, more and more programs use the cmake build system, its cross-platform aspect has advantages over make, and removing cmake in n2n is not a good choice.
I honestly have no idea how we can maintain the CMake system and how to always keep it in sync with the automake tools at each and every change.
As far as I can see, the main concern might be with Windows platform (for which we have/offer a solution)?
I always use CMAKE to cross compile N2N, which is much more convenient than MAKE. I do not wish to remove CMAKE.
On Wed, Aug 10, 2022 at 02:30:22AM -0700, llfj wrote:
I always use CMAKE to cross compile N2N, which is much more convenient than MAKE. I do not wish to remove CMAKE.
What do you need to improve the convenience of make. You see, I always use MAKE to cross compile N2N as it is much more convenient.
Also, who will maintain CMake here?
It is difficult to maintain one build system, let alone two - especially if one build system is known to be better maintained and the other build system continues to be used - with bug and feature requests raised against it.
The maintainers are aware that there are people using the CMake system, but believe that the extra maintainability of only having one build system, combined with the knowledge that the current CI system demonstrates that all supported architectures are working with the Makefiles make the use of these Makefiles a more sustainable direction.