search

ntop / n2n

Peer-to-peer VPN
GNU General Public License v3.0
6.22k stars 935 forks source link

Fix some bugs on Windows #1103

Closed hamishcoleman closed 1 year ago

hamishcoleman commented 1 year ago

Replacement for #1089 after I accidentally closed it

Legend-Master commented 1 year ago

I'm not sure how should I test this branch, would you mind I open another pull request from my fork's branch?

hamishcoleman commented 1 year ago

You can checkout this branch for testing pretty easily:

git checkout -b hamishcoleman-Legend-Master-dev dev
git pull git@github.com:hamishcoleman/n2n.git Legend-Master-dev

This branch contains the changes that I am suggesting

Legend-Master commented 1 year ago

Yes, I think it still works like before

hamishcoleman commented 1 year ago

Great!, thanks for testing

hamishcoleman commented 1 year ago

An unexpected side effect of the UAC prompt is that it /always/ prompts, and thus will /always/ run in a separate subshell - which makes debugging difficult and feels like a regression

Legend-Master commented 1 year ago

An unexpected side effect of the UAC prompt is that it /always/ prompts, and thus will /always/ run in a separate subshell - which makes debugging difficult and feels like a regression

I'm not sure how you debug it, for me, I run vscode/visual studio in admin mode even before the change to debug it, since it won't work without admin anyway

But yeah, it's kinda bad to have it flash a console window when running in a non admin terminal and quit immediately if all you want is just showing the help message