ntop / n2n

Peer-to-peer VPN
GNU General Public License v3.0
6.07k stars 927 forks source link

Fix purgeable is always false on supernode peer list #1117

Closed Legend-Master closed 1 year ago

Legend-Master commented 1 year ago

Fix a regression caused by #982

Purgeable was set to 0 through calloc and the change from SN_PURGEABLE = 0 to PURGEABLE = 1 broke this

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +1.00 :tada:

Comparison is base (e42cbd7) 22.62% compared to head (3cdbd22) 23.62%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1117 +/- ## ========================================== + Coverage 22.62% 23.62% +1.00% ========================================== Files 42 41 -1 Lines 8601 7403 -1198 ========================================== - Hits 1946 1749 -197 + Misses 6655 5654 -1001 ``` | [Impacted Files](https://app.codecov.io/gh/ntop/n2n/pull/1117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/edge\_management.c](https://app.codecov.io/gh/ntop/n2n/pull/1117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2VkZ2VfbWFuYWdlbWVudC5j) | `0.00% <0.00%> (ø)` | | | [src/edge\_utils.c](https://app.codecov.io/gh/ntop/n2n/pull/1117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2VkZ2VfdXRpbHMuYw==) | `1.78% <0.00%> (+0.10%)` | :arrow_up: | | [src/n2n.c](https://app.codecov.io/gh/ntop/n2n/pull/1117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL24ybi5j) | `1.15% <0.00%> (+0.05%)` | :arrow_up: | | [src/sn\_management.c](https://app.codecov.io/gh/ntop/n2n/pull/1117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NuX21hbmFnZW1lbnQuYw==) | `0.00% <0.00%> (ø)` | | | [src/sn\_utils.c](https://app.codecov.io/gh/ntop/n2n/pull/1117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL3NuX3V0aWxzLmM=) | `0.00% <0.00%> (ø)` | | | [tools/n2n-route.c](https://app.codecov.io/gh/ntop/n2n/pull/1117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dG9vbHMvbjJuLXJvdXRlLmM=) | `0.00% <ø> (ø)` | | ... and [32 files with indirect coverage changes](https://app.codecov.io/gh/ntop/n2n/pull/1117/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

hamishcoleman commented 1 year ago

Thanks!