ntop / n2n

Peer-to-peer VPN
GNU General Public License v3.0
6.28k stars 943 forks source link

Update README.md #911

Closed skyformat99 closed 2 years ago

skyformat99 commented 2 years ago

update readme.md

codecov-commenter commented 2 years ago

Codecov Report

Merging #911 (3c68052) into dev (87f0a7e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #911   +/-   ##
=======================================
  Coverage   19.77%   19.77%           
=======================================
  Files          43       43           
  Lines        8713     8713           
=======================================
  Hits         1723     1723           
  Misses       6990     6990           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87f0a7e...3c68052. Read the comment docs.

hamishcoleman commented 2 years ago

There is already some documentation in the doc/Building.md file - rather than making the main README.md bigger, perhaps we should remove the duplicate build details from the README file and continue to point people at the Building.md (possibly improving the Building file if needed)

Logan007 commented 2 years ago

@hamishcoleman I agree. Also, I still prefer the makey way as default. We could add CMaketo the enumeration of alternatives:

For Windows, MacOS, CMake and general building options, please check out Building documentation for compilation and running.

skyformat99 commented 2 years ago

@hamishcoleman I agree. Also, I still prefer the makey way as default. We could add CMaketo the enumeration of alternatives:

For Windows, MacOS, CMake and general building options, please check out Building documentation for compilation and running.

ok, I agree. close it.

Logan007 commented 2 years ago

No need to close, we can adapt it.