search

ntop / n2n

Peer-to-peer VPN
GNU General Public License v3.0
6.19k stars 934 forks source link

3.0 stable - unnecessary patch for OpenWRT #921

Closed siskai closed 2 years ago

Logan007 commented 2 years ago

I am not sure why this would point to another repository. Maybe some residual?

@hamishcoleman what do you think?

hamishcoleman commented 2 years ago

Thanks for reminding me - I made a similar fix in dev, but forgot that it was also affecting the stable branch.

We definitely want to remove the patch to let it actually build, and fix the version number.

It might also be a good moment to look at the other changes in the packages/openwrt/Makefile from the dev branch to see if any are applicable for a stable branch.

@siskai, For the simple option, you can split this into two PRs - the first with the patch file remove - then once that is merged you can reference a PKG_SOURCE_VERSION that is known to exist in the stable branch in a second PR (with the right PKG_SOURCE_URL). However, if you wanted, you could also look at the openwrt build changes in dev and back-port a stable-suitable version of that.

siskai commented 2 years ago

My fault, url should refer to the original repository.

I'll fix it.