ntop / n2n

Peer-to-peer VPN
GNU General Public License v3.0
6.28k stars 943 forks source link

ManagementAPI can add query options #924

Closed seayxu closed 2 years ago

seayxu commented 2 years ago

Add community and ip options for edges of supernode, like below.

r 999:0 edges c1
r 999:0 edges c1 10.1.2.3
# or
r 999:0 edges c1,c2

It is very necessary when community is too much.

hamishcoleman commented 2 years ago

I assumed that the client would do any needed filtering, as that allows the server to remain simple.

How many edges are you dealing with?

seayxu commented 2 years ago

Thousands but not now,will continue to increase

hamishcoleman commented 2 years ago

Have you done any testing with that number of edges? Are you seeing any specific issues?

Remember the ManagementAPI is not expected to be typed in by humans, so the client is a good place to add any complex filtering system (Are you using the n2n-ctl example client?)

seayxu commented 2 years ago

Understood,thank you.

hamishcoleman commented 2 years ago

Please do return with more info if you find scaling issues. I don't believe anyone has tested the ManagementAPI with that number of edges.