search

ntop / n2n

Peer-to-peer VPN
GNU General Public License v3.0
6.18k stars 930 forks source link

Fixed coredump #999

Closed small-5 closed 2 years ago

small-5 commented 2 years ago

Fix https://github.com/ntop/n2n/issues/991

codecov-commenter commented 2 years ago

Codecov Report

Merging #999 (f1899f4) into dev (a274818) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #999      +/-   ##
==========================================
- Coverage   21.03%   21.03%   -0.01%     
==========================================
  Files          43       43              
  Lines        8327     8328       +1     
==========================================
  Hits         1752     1752              
- Misses       6575     6576       +1
Impacted Files Coverage Δ
src/edge_utils.c 1.59% <0.00%> (-0.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a274818...f1899f4. Read the comment docs.

hamishcoleman commented 2 years ago

Are you able to explain how this fixes the coredumps? None of the code you have touched is dereferencing any pointers that could lead to a coredump. Also, a zero return value is a valid result for the sendto() function, so that seems wrong.

Are you actually able to replicate this coredump? can you run diagnostics to work out where the coredump is occuring? It is somewhere upstream of these functions and would be really good to know where so we can fix the cause.