ntop / nDPI

Open Source Deep Packet Inspection Software Toolkit
http://www.ntop.org
GNU Lesser General Public License v3.0
3.86k stars 902 forks source link

Improved Kafka dissector. #2456

Closed utoni closed 6 months ago

utoni commented 6 months ago

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Some Kafka packets were not detected on my side. The behavior is pretty much the same, but no additional flow memory needed anymore. Asymmetric detection is not implemented and was not before (dissector was relying on a previously seen request packet), but can be done in the future (see kafka.pcap asym responses captured).

utoni commented 6 months ago

Note: I removed current_pkt_from_client_to_server(), because it does not work reliable on my side (I do not provide struct ndpi_flow_input_info to ndpi_detection_process_packet()).

IvanNardi commented 6 months ago

Is it possible to merge the two kafka traces?

utoni commented 6 months ago

libpcap does not like having different interface types in one pcap file. Do you know how I can change that? :smile:

0xA50C1A1 commented 6 months ago

libpcap does not like having different interface types in one pcap file. Do you know how I can change that? 😄

I only know one way, but it's pretty crude and dumb..... recreate the session with scappy.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud