ntop / nDPI

Open Source Deep Packet Inspection Software Toolkit
http://www.ntop.org
GNU Lesser General Public License v3.0
3.86k stars 901 forks source link

dns: add a check before setting `NDPI_MALFORMED_PACKET` risk #2558

Closed IvanNardi closed 2 months ago

IvanNardi commented 2 months ago

"Invalid DNS Header"-risk should be set only if the flow has been already classified as DNS. Otherwise, almost any non-DNS flows on port 53 will end up having the NDPI_MALFORMED_PACKET risk set, which is a little bit confusing for non DNS traffic

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud